-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Backend Architecture for the AasRepository and AasService #570
Merged
aaronzi
merged 30 commits into
eclipse-basyx:main
from
mateusmolina-iese:feat/repositories-consolidation
Feb 4, 2025
Merged
Refactor Backend Architecture for the AasRepository and AasService #570
aaronzi
merged 30 commits into
eclipse-basyx:main
from
mateusmolina-iese:feat/repositories-consolidation
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06f95ce
to
b659e26
Compare
… improving interface expectations
aaronzi
reviewed
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. Implementation wise this looks fine to me. I just added a small suggestion
...nd/src/main/java/org/eclipse/digitaltwin/basyx/core/filerepository/FileRepositoryHelper.java
Show resolved
Hide resolved
…-sdk into feat/repositories-consolidation
aaronzi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #555
Linked to 1st Phase of #584
aasservice-backend-mongodb
package while being utilized byaasrepository-backend-mongodb
by registering a Bean with the expected naming convention. This approach enhances flexibility and control over the overall backend implementation.